Broken links in dbDoc

Description

I am experimenting with Liquibase and my project has 3 changelog files. One master that includes two others.

My structure is as follows:

db.changelog-master.xml
changes/db.changelog-01.xml
changes/db.changelog-02.xml

When I run dbDoc it creates the HTML files but links for included changelogs are broken. In folder changelogs/changes there are two files named db.changelog-01.xml.html and db.changelog-02.xml.html, as expected. What it is not expected is that both are equal to my master changelog file!

Besides that, please note that I use a hyphen to separate "change" from the sequential number ("01" or "02"). However, in changelogs.html I can see that hrefs for the file use an underscore '_' instead of hyphen:

changelogs/changes/db.changelog_02.xml.html

I guess this is not expected behavior but there is always the chance I might be doing something wrong. Thanks in advance for your time.

Environment

Windows 7

Activity

Show:
Nathan Voxland
December 11, 2013, 9:45 PM

Fixed the issue with child changeLogs not being populated correctly.

The href change is expected behavior because we want to create files that are filesystem-safe. Hyphens can sometimes cause problems so we translate them. It is just for the file names and doesn't affect the info displayed in the html.

Piyush Bhatt
January 9, 2014, 1:46 PM

Hi Nathan,

I am getting the same issue in 3.0.8 as well. I generated dbdoc for a changelog having the name as full-install-1.0.xml

However when try to see it in browser the href value is still showing an _(underscore) instead of hyphen but the files in the dbdoc directory have a hyphen

In the best practices page, changelog names have a -(hyphen). So is that still good or _(underscore) is better practice to use in the changelog file names

Regards
Piyush

Nathan Voxland
January 9, 2014, 3:16 PM

You are right. Hyphens are fine in file names. I changed it so they are not translated in 3.1.0.

Fixed

Reporter

Nei Barbosa

Components

Fix versions

Affects versions

Priority

Major