New constraint attributes break the Liquibase Groovy DSL

Description

By convention, all of the xml attributes of of a change element have matching variables in the corresponding Java class, with standard get/set methods. The Groovy DSL is depending on that convention to parse the groovy changlogs and create change sets.

Liquibase 3.7.0 added 4 new attributes to the Conatraints element: validateNullable, validateUnique, validatePrimaryKey, and validateForeignKey, but the get/set methods are called shouldValidateNullable, shouldValidateUnique, etc.

I can submit a pull request that renames all the "shouldValidate" methods to "getValidate" and "setValidate", possibly leaving the old methods behind as deprecated methods in case some other external project is using them, or I could remove them so no one starts using them.

It looks like there are a fair number of classes that would be effected, so how would you like me to proceed? This issue is currently blocking me from releasing a new version of the Groovy DSL that supports version 3.7.0

Steve

Environment

All

Status

Assignee

Unassigned

Reporter

Steve Saliman

Labels

None

Components

Affects versions

Priority

Major
Configure