Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Colons in changeSet IDs no longer supported

Description

UpdateGenerator have changed recently to support magic strings ":value" and ":name". Consider however following scenario:

  • you create changeSet with id="whatever:value"

  • it is applied on the database

  • somehow checkSum is cleared

  • Liquibase attempts to recreate checkSum

Now - Liquibase will generate UpdateStatement for checksum, which contains ID in where clause. Since ID is "whatever:value", magic will happen and ":value" will be replaced with something. In my case on mssql this even produces SQL that is invalid.

Therefore: is it a bug? Can you change these tokens to something less commonly used? Can you add possibility to turn off this/modify tokens? Or maybe having colons in ID is forbidden?

Environment

unrelated

Activity

Show:

Nathan Voxland May 28, 2014 at 8:30 PM

I'm not able to reproduce this issue with the current 3.2.0 snapshot. Probably fixed with a general change to parsing I made.

Nathan Voxland January 31, 2014 at 3:10 PM

Thanks, I can get that fixed.

Tomasz Warchol January 30, 2014 at 3:28 PM

When attempting to recreate checkSum for some changeSet X, Liquibase is generating UpdateStatement with where clause containing X's id. So this logic will be applied to this ID. That is the problem.

Nathan Voxland January 6, 2014 at 10:57 PM

The :value and :name logic isn't being applied to the id, so I don't think this is an issue.

Nathan Voxland January 6, 2014 at 10:55 PM

It will only apply if you are using a whereParams node.

Fixed

Details

Reporter

Components

Fix versions

Affects versions

Priority

Created December 18, 2013 at 5:36 PM
Updated May 28, 2014 at 8:30 PM
Resolved May 28, 2014 at 8:30 PM