Computations are truncated if they begin with CURRENT_TIMESTAMP
Description
If you have a computation for defaultValueComputed in a column specification which starts with current_timestamp it gets truncated to current_timestamp (or whatever the currentTimeFunction for the DB is)
A workaround is obviously to change the computation to not start with CURRENT_TIMESTAMP either by reordering or adding parenthesis.
This is a very subtle bug and i think at least the documentation should warn very clear about this behavior. I understand that this behavior tries to work around Databases who do not follow the standard. I cannot assess how much impact it would make to fix this in a correct way, which does not silently change my refactoring. Maybe this can only be done for these somewhat broken databases.
Major
If you have a computation for defaultValueComputed in a column specification which starts with current_timestamp it gets truncated to current_timestamp (or whatever the currentTimeFunction for the DB is)
eg.
<column defaultValueComputed="CURRENT_TIMESTAMP + interval '2 days'"/>
gets truncated to
<column defaultValueComputed="CURRENT_TIMESTAMP'"/>
This was not in version 1.9.5 And we found it only after migrating to Liquibase 3.0.8
The problem is in AbstractJdbcDatabase:1717 (at version 3.0.8)
private boolean isCurrentTimeFunction(final String functionValue) {
return functionValue.startsWith("current_timestamp")
functionValue.startsWith("current_datetime")
getCurrentDateTimeFunction().equalsIgnoreCase(functionValue);
}
A workaround is obviously to change the computation to not start with CURRENT_TIMESTAMP either by reordering or adding parenthesis.
This is a very subtle bug and i think at least the documentation should warn very clear about this behavior. I understand that this behavior tries to work around Databases who do not follow the standard. I cannot assess how much impact it would make to fix this in a correct way, which does not silently change my refactoring. Maybe this can only be done for these somewhat broken databases.