Reported size for Oracle NVARCHAR2 columns is wrong
Description
Environment
Linux Oracle10
Activity
Show:
Nathan Voxland August 27, 2014 at 8:33 PM
Merged pull request
Xavier Poinsard July 25, 2014 at 3:18 PM
See proposed pull : https://github.com/liquibase/liquibase/pull/290
Exactly same issue than https://liquibase.jira.com/browse/CORE-1552#icft=CORE-1552 : liquibase report 127 for size instead of 255.
The wrong line is in ColumnSnapshotGenerator.java line 206.
The result is already in chars since the NVARCHAR2 type implies you can only specify sizes in chars.
It doesn't require any division.
I think the safest way of solving this issue is to use the CHAR_LENGTH column instead of DATA_LENGTH for characters columns.
See : http://docs.oracle.com/cd/B19306_01/server.102/b14237/statviews_2094.htm