Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Column snapshot on PostgreSQL does not include precision information for numeric data type

Description

steps

  • take table/column snapshot of a numeric(10,5) column on PostgreSQL database

expected

  • information that it was numeric(10,5)

    OBSERVED

  • information that it was numeric but no more

note

This is because of

ColumnSnapshotGenerator.readDataType(CachedRow, Column, Database)

if (database.dataTypeIsNotModifiable(columnTypeName)) { columnSize = null; }

ATM, the database.dataTypeIsNotModifiable(...) method returns true only on PostgreSQL, for several data types including numeric – perhaps just need to remove "numeric" from the list?

Environment

PostgreSQL 9.3.5

Activity

Show:

Nathan Voxland October 21, 2014 at 5:13 PM

Fixed for 3.3.0

Piotr Findeisen October 21, 2014 at 1:31 PM

btw. I think the unmodifiableDataTypes would welcome addition of "text" – this once seems unmodifiable.

Fixed

Details

Reporter

Fix versions

Affects versions

Priority

Created October 21, 2014 at 1:19 PM
Updated October 21, 2014 at 5:13 PM
Resolved October 21, 2014 at 5:13 PM
Configure