Change formatted SQL stripComments default from "true" to "false"

Description

hello!

My name is Raste, i work on a project and it is kind of urgent to fix this bug.
i have comments in my plsql code, but these comments disappear when i deploy via liquibase.

here is my code:

--liquibase formatted sql
--changeset procedure_x_rbg_comment_test:4 (splitStatements:false)
create or replace function x_rbg_comment_test
as
v_sysdate date;

begin

--select into variable
/* select into variable*/

select sysdate
into v_sysdate
from dual ;

end;

the two comments after begin ( --select into variable and /* select into variable*/) disappear in this case, what i see in the database is something like this.

CREATE OR REPLACE function .x_rbg_comment_test
as
v_sysdate date;

begin

select sysdate
into v_sysdate
from dual ;

end;

OBS! i have latest version of liquibase Version: 3.3.5

Regards
Raste

Environment

liquibase verions 3.3.5

Activity

Show:

Nathan Voxland July 27, 2015 at 5:52 PM

Reverting in 3.4.1 with due to checksum issues. Will re-apply in 4.0

Nathan Voxland June 19, 2015 at 6:37 PM

Fixed, the default for stripComments was "true" but I changed it to "false" now that 3.4 better parses SQL.

Details

Reporter

Components

Fix versions

Affects versions

Priority

Created June 2, 2015 at 2:53 PM
Updated July 27, 2015 at 5:52 PM