runOnChange change set runs every time even if there wasn't changed

Now checking for duplicates, even though there technically shouldn't be.

We use 3.5.0 version and both Mysql and Oracle environments face with this issue.
As I remember we used loadUpdateData tag, but i think tag is not matter.
You just can look at source code of ShouldRunChangeSetFilter.accepts(ChangeSet) method. There are walking through ALL change sets and matching with ANY change set, even with the same change set but executed older. Of course if we match current change set(that ran because check sum was changed) with older change set's check sum it will be always different. And once we encounter with older change set:

filter returns change set should be ran.
The only chance this should work properly if liquibase has different implementation of component that fetch ran change sets. In case of Mysql and Oracle we encountered it load all change sets, duplicating the same(by id) change sets in the entire list.

>>Your steps make sense, but I'm not getting an extra changelog row.
>>I ran a changeSet of:
I will try to reproduce the bug with your test case with table tomorrow cause now i don't have access to my workstation.

Even with 3.4.1 against sqlserver I'm not able to replicate the multi-row problem.

I may need to bring the pull request in anyway to avoid issues however there gets to be multiple rows, but there shouldn't be and I'd like to understand how it's happening.

Are you using updateSql or anything?

That sounds pretty similar - we're using delete+loadData to repopulate some seed data from a csv file, but I can't imagine the type of the migration makes a difference.

And we only see a single row, up until the changeset is modified - that's when we start seeing multiple rows.

This is running liquibase 3.4.1 against MS SQL Server.

Your steps make sense, but I'm not getting an extra changelog row.

I ran a changeSet of:

<changeSet author="test" id="1" runOnChange="true">
<createTable tableName="test_table1">
<column name="id" type="int"/>
</createTable>
</changeSet>

which created the table. Re-running liquibase with no changes does not re-execute the changeSet.

I updated the changeSet to be (notice the changed table name):

<changeSet author="test" id="1" runOnChange="true">
<createTable tableName="test_table2">
<column name="id" type="int"/>
</createTable>
</changeSet>

and liquibase successfully created the table, then on re-executes it does not re-run it. There remains only one row in the changelog table.

Is that different than you were trying to do? What Liqubibase version were you running?