Make Load*DataChange aware of ChangeLogParameters

Description

As of version 3.5.2, placeholders like ${foo.bar} in csv files are not resolved against changelog parameters.
Please introduce parameter filtering in Load*DataChange. This new feature should be activatable via a new attribute (deactivated by default for backward compatibility).

Environment

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
Maven home: C:\Program Files\apache-maven-3.3.9
Java version: 1.8.0_102, vendor: Oracle Corporation
Java home: C:\Develop\CCS\jdk1.8.0_102\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

Activity

Show:

Ulf Lindback August 1, 2019 at 11:55 AM

I've created a pull request to fix this:
https://github.com/liquibase/liquibase/pull/902
I solved the "This new feature should be activatable via a new attribute" by only activating the feature if a ChangeLog parameter: enableCsvParameterSubstitution is set to true, not sure if that is the best approach, so please give feedback on how to do it in other ways. Could probably add a command line parameter which sets enableCsvParameterSubstitution internally.

Details

Reporter

Affects versions

Priority

Created November 22, 2016 at 3:56 PM
Updated August 1, 2019 at 11:55 AM