Comments at end of statements are incorrectly parsed
Description
Environment
Liquibase 3.5.3, sqlFile and Oracle Database
Activity
Show:
Nathan Voxland July 16, 2019 at 7:14 PM
Moving to 3.7.0 release
Nathan Voxland July 2, 2019 at 10:00 PM
I may actually just do a 3.7.0 which includes this and a few other changes, then see if there is a need for a 3.6.x release.
Endre Jeges June 19, 2019 at 8:15 AM
The fix has been pulled into master branch that is 3.7.0. Will this be backported to 3.6.4 as this JIRA ticket refers to?
Nathan Voxland June 18, 2019 at 3:22 PM
Merged pull request
Matteo Turra January 31, 2019 at 8:47 AMEdited
The regular expression in liquibase.executor.jvm.JdbcExecutor.ExecuteStatementCallback#doInStatement should be changed in (see red not matching *): [\\s\\r\\n]
/[\\s\\r
n]$
The following changeset:
fails with a DatabaseException:
because Liquibase breaks comment which is at end of the statement.
This is a proper syntax which we sometimes use to comment magic numbers that appear in `WHERE ` part of our views. AFAIR it worked correctly in Liquibase 3.4.